[orca] Revert "Don't call saveFocusedObjectInfo() in setCaretPosition()"
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Revert "Don't call saveFocusedObjectInfo() in setCaretPosition()"
- Date: Wed, 22 Jan 2020 19:32:29 +0000 (UTC)
commit 059e013cd803e50980f845e03e797440a5d996a7
Author: Joanmarie Diggs <joanmarie diggs gmail com>
Date: Wed Jan 22 14:29:32 2020 -0500
Revert "Don't call saveFocusedObjectInfo() in setCaretPosition()"
This reverts commit 716d2b9e099e2e2cea2a94f1f8ab5f26ce277fec.
When we set the caret position and update the locusOfFocus without
notifying the script, state isn't getting saved. We should consider
refining setLocusOfFocus to update all state even when the script
shouldn't be "notified" (which really means "don't present this change
to the user"). Doing that cleanly is a bigger change. So reverting for
now.
src/orca/scripts/web/script_utilities.py | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 0aae05c9b..921f3369a 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -449,6 +449,9 @@ class Utilities(script_utilities.Utilities):
if obj:
obj.clearCache()
+ # TODO - JD: This is private.
+ self._script._saveFocusedObjectInfo(obj)
+
def getNextObjectInDocument(self, obj, documentFrame):
if not obj:
return None
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]