[gnome-shell/wip/carlosg/osk-widgetry-fixes: 4/5] keyboard: Do not reset to initial page on unmap



commit acf0e27bb9dfe22c6ae6a69c7d6ae8623f0d9e20
Author: Carlos Garnacho <carlosg gnome org>
Date:   Tue Jan 21 16:35:07 2020 +0100

    keyboard: Do not reset to initial page on unmap
    
    It will happen before next map anyway, and most notably at times
    actor sizes produce correct results.
    
    Fixes oddities in emoji pager visibility after showing the emoji
    panel, moving to another page, and hiding the OSK with the downward
    arrow button. The next time the emoji panel would be shown, panels
    had a chance to remain invisible.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/943

 js/ui/keyboard.js | 5 -----
 1 file changed, 5 deletions(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 7f7e8a4e5c..3a32962007 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -942,11 +942,6 @@ var EmojiSelection = GObject.registerClass({
         super.vfunc_map();
     }
 
-    vfunc_unmap() {
-        super.vfunc_unmap();
-        this._emojiPager.setCurrentPage(0);
-    }
-
     _onPageChanged(sectionLabel, page, nPages) {
         this._curPage = page;
         this._pageIndicator.setNPages(nPages);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]