[vala/wip/ricotz/lsp-rev: 2/8] vala: Always bail if there are semantic errors

[Rico Tzschichholz <ricotz src gnome org>]

commit b0844bc2d18759f18431c8f00181c716cff70def
Author: Princeton Ferro <princetonferro gmail com>
Date:   Sat Jan 18 20:03:37 2020 +0100

    vala: Always bail if there are semantic errors
    
    Previously introduced by 1430c461d4a45026331663989113feb195588255

 vala/valacodecontext.vala | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/vala/valacodecontext.vala b/vala/valacodecontext.vala
index 9bce9f19d..1c3ad77cd 100644
--- a/vala/valacodecontext.vala
+++ b/vala/valacodecontext.vala
@@ -520,7 +520,9 @@ public class Vala.CodeContext {
 
                analyzer.analyze (this);
 
-               if (!keep_going && report.get_errors () > 0) {
+               // Don't run the FlowAnalyzer if we have semantic errors, since
+               // the messages from FlowAnalyzer will usually be nonsensical.
+               if (report.get_errors () > 0) {
                        return;
                }