[retro-gtk] retro-core: Remove return result from message signal



commit 893c4637c2145a9bd88cbec7847bfd18c887526a
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Mon Jan 6 19:02:44 2020 +0500

    retro-core: Remove return result from message signal
    
    This will be a problem later, as sending a message will be async, so
    don't return anything.

 retro-gtk/retro-core.c        | 4 +---
 retro-gtk/retro-environment.c | 5 ++---
 2 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/retro-gtk/retro-core.c b/retro-gtk/retro-core.c
index a243595..e49d917 100644
--- a/retro-gtk/retro-core.c
+++ b/retro-gtk/retro-core.c
@@ -521,14 +521,12 @@ retro_core_class_init (RetroCoreClass *klass)
    *
    * The ::message signal is emitted each time the core emits a message to
    * display during a given amount of frames.
-   *
-   * Returns: whether the request got fulfilled
    */
   signals[SIG_MESSAGE_SIGNAL] =
     g_signal_new ("message", RETRO_TYPE_CORE, G_SIGNAL_RUN_LAST,
                   0, NULL, NULL,
                   NULL,
-                  G_TYPE_BOOLEAN,
+                  G_TYPE_NONE,
                   2,
                   G_TYPE_STRING,
                   G_TYPE_UINT);
diff --git a/retro-gtk/retro-environment.c b/retro-gtk/retro-environment.c
index af83b16..0791563 100644
--- a/retro-gtk/retro-environment.c
+++ b/retro-gtk/retro-environment.c
@@ -366,10 +366,9 @@ static gboolean
 set_message (RetroCore          *self,
              const RetroMessage *message)
 {
-  gboolean result = FALSE;
-  g_signal_emit_by_name (self, "message", message->msg, message->frames, &result);
+  g_signal_emit_by_name (self, "message", message->msg, message->frames);
 
-  return result;
+  return TRUE;
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]