[libgdamm] Holder: Remove get/set_attribute()



commit 8890b62b69c1a32f6b936dc6d55e8310c57b04bc
Author: Murray Cumming <murraycu google com>
Date:   Sun Jan 19 19:56:16 2020 +0100

    Holder: Remove get/set_attribute()
    
    gda_holder_get/set_attribute() seems to have been removed from libgda.

 libgda/src/holder.ccg | 13 -------------
 libgda/src/holder.hg  |  7 -------
 2 files changed, 20 deletions(-)
---
diff --git a/libgda/src/holder.ccg b/libgda/src/holder.ccg
index 24c087c..7d13c52 100644
--- a/libgda/src/holder.ccg
+++ b/libgda/src/holder.ccg
@@ -35,19 +35,6 @@ Holder::Holder (GType g_type, const Glib::ustring& id)
 {
 
 }
-
-static void on_set_attribute_destroy(gpointer data)
-{
-  g_free((char*)data);
-}
-
-void Holder::set_attribute(const Glib::ustring& attribute, const Value& value)
-{
-  //gda_holder_set_attribute() has stupid memory management.
-  //See http://bugzilla.gnome.org/show_bug.cgi?id=564402
-  gchar* dup = g_strdup(attribute.c_str());
-  gda_holder_set_attribute(gobj(), dup, (value).gobj(), &on_set_attribute_destroy); 
-}
   
 } /* namespace Gda */
 
diff --git a/libgda/src/holder.hg b/libgda/src/holder.hg
index 4d1859f..d10370e 100644
--- a/libgda/src/holder.hg
+++ b/libgda/src/holder.hg
@@ -71,12 +71,6 @@ public:
   _WRAP_METHOD(bool take_value(const Value& value), gda_holder_take_value, errthrow)
   _WRAP_METHOD(Value take_static_value (const Value& value, bool& value_changed), 
gda_holder_take_static_value, errthrow)
 
-  void set_attribute(const Glib::ustring& attribute, const Value& value);
-  _IGNORE(gda_holder_set_attribute)
-  //TODO: gda_holder_set_attribute() has stupid memory management: _WRAP_METHOD(void set_attribute(const 
Glib::ustring& attribute, const Value& value), gda_holder_set_attribute)
-
-  _WRAP_METHOD(Value get_attribute(const Glib::ustring& attribute) const, gda_holder_get_attribute) 
-  
   _WRAP_METHOD(Value get_default_value() const, gda_holder_get_default_value)
   _WRAP_METHOD(void set_default_value(const Value& value), gda_holder_set_default_value)
   _WRAP_METHOD(bool set_value_to_default(), gda_holder_set_value_to_default)
@@ -123,7 +117,6 @@ public:
   
 #m4 _CONVERSION(`const char*',`const Glib::ustring&',__GCHARP_TO_USTRING)
   _WRAP_SIGNAL(void attribute_changed(const Glib::ustring& attr_name, const Value& value), 
"attribute-changed", no_default_handler)
-
 };
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]