[epiphany/mcatanzaro/view-source-context-menu] Hide view page source context menu items when required
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/view-source-context-menu] Hide view page source context menu items when required
- Date: Sat, 11 Jan 2020 20:59:27 +0000 (UTC)
commit 2f67c2b9f3beb228be11b3b69305b2463c3feb59
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sat Jan 11 14:53:33 2020 -0600
Hide view page source context menu items when required
Doesn't make sense to allow view page source or inspect element when we
are already on a view source page.
Fixes #1046
src/ephy-window.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/src/ephy-window.c b/src/ephy-window.c
index 59f0e661f..c001fe374 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -54,6 +54,7 @@
#include "ephy-title-box.h"
#include "ephy-title-widget.h"
#include "ephy-type-builtins.h"
+#include "ephy-view-source-handler.h"
#include "ephy-web-app-utils.h"
#include "ephy-web-view.h"
#include "ephy-zoom.h"
@@ -1491,6 +1492,7 @@ populate_context_menu (WebKitWebView *web_view,
char *search_selection_action_name = NULL;
char *open_selection_action_name = NULL;
const char *selected_text = NULL;
+ const char *uri = NULL;
if (g_settings_get_boolean (EPHY_SETTINGS_LOCKDOWN,
EPHY_PREFS_LOCKDOWN_CONTEXT_MENU))
@@ -1773,8 +1775,12 @@ populate_context_menu (WebKitWebView *web_view,
webkit_context_menu_append (context_menu,
webkit_context_menu_item_new_separator ());
- add_action_to_context_menu (context_menu, window_action_group,
- "page-source", window);
+ uri = webkit_web_view_get_uri (web_view);
+ if (uri && !strstr (uri, EPHY_VIEW_SOURCE_SCHEME)) {
+ add_action_to_context_menu (context_menu, window_action_group,
+ "page-source", window);
+ }
+
webkit_context_menu_append (context_menu,
webkit_context_menu_item_new_from_stock_action
(WEBKIT_CONTEXT_MENU_ACTION_INSPECT_ELEMENT));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]