[gnome-shell/gbsneto/folders-as-dialogs: 5/5] appDisplay: Don't change icon opacity when showing folder dialog

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit f3aa12f0bbd58ae145f6c0818472d40887716fc3
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Jan 9 17:06:59 2020 -0300

    appDisplay: Don't change icon opacity when showing folder dialog
    
    The app grid changes the icon opacities when an app folder dialog is
    open. As per design guidance, stop doing that.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/896

 js/ui/appDisplay.js | 21 ---------------------
 1 file changed, 21 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index b90e7c77d5..4eae9f4ee2 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -24,10 +24,6 @@ var MAX_COLUMNS = 6;
 var MIN_COLUMNS = 4;
 var MIN_ROWS = 4;
 
-var INACTIVE_GRID_OPACITY = 77;
-// This time needs to be less than IconGrid.EXTRA_SPACE_ANIMATION_TIME
-// to not clash with other animations
-var INACTIVE_GRID_OPACITY_ANIMATION_TIME = 240;
 var FOLDER_SUBICON_FRACTION = .4;
 
 var MIN_FREQUENT_APPS_COUNT = 3;
@@ -713,7 +709,6 @@ var AllView = GObject.registerClass({
                     this._eventBlocker.visible = false;
                 });
             }
-            this._updateIconOpacities(isOpen);
             this._displayingPopup = isOpen;
         });
     }
@@ -723,22 +718,6 @@ var AllView = GObject.registerClass({
         this.goToPage(itemPage);
     }
 
-    _updateIconOpacities(folderOpen) {
-        for (let icon of this._items.values()) {
-            let opacity;
-            if (folderOpen && !icon.checked)
-                opacity =  INACTIVE_GRID_OPACITY;
-            else
-                opacity = 255;
-
-            icon.ease({
-                opacity,
-                duration: INACTIVE_GRID_OPACITY_ANIMATION_TIME,
-                mode: Clutter.AnimationMode.EASE_OUT_QUAD,
-            });
-        }
-    }
-
     // Called before allocation to calculate dynamic spacing
     adaptToSize(width, height) {
         let box = new Clutter.ActorBox();