[gimp] plug-ins: variable used after being freed.
- From: Jehan <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] plug-ins: variable used after being freed.
- Date: Fri, 3 Jan 2020 19:02:19 +0000 (UTC)
commit 2cd765c000065e180f6dbc6e1baf8b242b280d24
Author: Jehan <jehan girinstud io>
Date: Fri Jan 3 19:57:59 2020 +0100
plug-ins: variable used after being freed.
Once again spotted by Massimo in #4449.
plug-ins/file-webp/file-webp-load.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/plug-ins/file-webp/file-webp-load.c b/plug-ins/file-webp/file-webp-load.c
index 25dad27f62..f27066cf63 100644
--- a/plug-ins/file-webp/file-webp-load.c
+++ b/plug-ins/file-webp/file-webp-load.c
@@ -104,14 +104,13 @@ load_image (GFile *file,
return NULL;
}
- g_free (filename);
-
/* Validate WebP data */
if (! WebPGetInfo (indata, indatalen, &width, &height))
{
g_set_error (error, G_FILE_ERROR, 0,
_("Invalid WebP file '%s'"),
gimp_file_get_utf8_name (file));
+ g_free (filename);
return NULL;
}
@@ -120,7 +119,10 @@ load_image (GFile *file,
mux = WebPMuxCreate (&wp_data, 1);
if (! mux)
- return NULL;
+ {
+ g_free (filename);
+ return NULL;
+ }
WebPMuxGetFeatures (mux, &flags);
@@ -164,6 +166,7 @@ load_image (GFile *file,
if (! outdata)
{
WebPMuxDelete (mux);
+ g_free (filename);
return NULL;
}
@@ -195,6 +198,7 @@ load_image (GFile *file,
}
WebPMuxDelete (mux);
+ g_free (filename);
return NULL;
}
@@ -293,6 +297,7 @@ load_image (GFile *file,
gimp_image_set_file (image, file);
+ g_free (filename);
if (profile)
g_object_unref (profile);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]