[mutter/gbsneto/dmabuf-screencast: 4/4] monitor-stream-src: Use cogl_framebuffer_finish()



commit 09026e5f0e948c1ba56508a48f8ce92eced31c8b
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Fri Feb 28 15:47:23 2020 -0300

    monitor-stream-src: Use cogl_framebuffer_finish()
    
    Even though cogl_framebuffer_flush() was supposed to be enough,
    it ends up creating streams with odd visual glitches that look
    very much like unfinished frames.
    
    Switch back to cogl_framebuffer_finish(), which is admittedly
    an overkill, but it's what works for now. There is anedoctal
    evidence showing it doesn't incur in worse performance.
    
    https://gitlab.gnome.org/GNOME/mutter/merge_requests/1086

 src/backends/meta-screen-cast-monitor-stream-src.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/backends/meta-screen-cast-monitor-stream-src.c 
b/src/backends/meta-screen-cast-monitor-stream-src.c
index f8f6d4be7..5f93b3000 100644
--- a/src/backends/meta-screen-cast-monitor-stream-src.c
+++ b/src/backends/meta-screen-cast-monitor-stream-src.c
@@ -436,7 +436,7 @@ meta_screen_cast_monitor_stream_src_blit_to_framebuffer (MetaScreenCastStreamSrc
         }
     }
 
-  cogl_framebuffer_flush (framebuffer);
+  cogl_framebuffer_finish (framebuffer);
 
   return TRUE;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]