[NetworkManager-openvpn] build: disable libnm-glib support by default

[Beniamino Galvani <bgalvani src gnome org>]

commit 071b23eed0ec7d37b19e9c33c15a1f5bd691b61f
Author: Lubomir Rintel <lkundrak v3 sk>
Date:   Wed Oct 17 15:21:30 2018 +0200

    build: disable libnm-glib support by default
    
    By now nobody should be using this. Keep the code around for a little
    longer just in case anybody still uses this.
    
    The libnm-glib support also serves as an example how do we build two
    different versions of the properties plugin. We'll soon be in a similar
    situation with Gtk 4.0. (sigh.) Just don't drop it yet.

 NEWS         | 4 ++++
 configure.ac | 8 ++++----
 2 files changed, 8 insertions(+), 4 deletions(-)
---
diff --git a/NEWS b/NEWS
index 7af39d6..805ee83 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,10 @@ Overview of changes since NetworkManager-openvpn-1.8.10
 * The auth helper in external UI mode can now be run without a display
   server. Future nmcli version will utilize this for handling the
   secrets without a graphical desktop.
+* libnm-glib compatibility (NetworkManager < 1.0) is disabled by default.
+  It can be enabled by passing --with-libnm-glib to configure script.
+  Nobody should need it by now. Users that still use this are encouraged
+  to let us know before the libnm-glib support is removed for good.
 
 =======================================================
 NetworkManager-openvpn-1.8.10
diff --git a/configure.ac b/configure.ac
index 3033a29..8fb6f73 100644
--- a/configure.ac
+++ b/configure.ac
@@ -75,7 +75,7 @@ dnl
 dnl GNOME support
 dnl
 AC_ARG_WITH(gnome, AS_HELP_STRING([--without-gnome], [Build NetworkManager-openvpn without GNOME support, 
e.g. vpn service only]), [], [with_gnome_specified=no])
-AC_ARG_WITH(libnm-glib, AS_HELP_STRING([--without-libnm-glib], [Build NetworkManager-openvpn without 
libnm-glib comatibility]), [], [with_libnm_glib_specified=no])
+AC_ARG_WITH(libnm-glib, AS_HELP_STRING([--with-libnm-glib], [Build NetworkManager-openvpn with libnm-glib 
compatibility (deprecated)]), [], [with_libnm_glib_specified=no])
 if test "$with_libnm_glib_specified" != no -a "$with_libnm_glib" != no; then
        if test "$with_gnome_specified" != no -a "$with_gnome" == no; then
                AC_MSG_ERROR(Building --with-libnm-glib conflicts with --without-gnome)
@@ -85,10 +85,10 @@ if test "$with_gnome" != no; then
        with_gnome=yes
 fi
 if test "$with_libnm_glib_specified" == no; then
-       with_libnm_glib="$with_gnome"
+       with_libnm_glib=no
 fi
-if test "$with_libnm_glib" != no; then
-       with_libnm_glib=yes
+if test "$with_libnm_glib" != yes; then
+       with_libnm_glib=no
 fi
 AM_CONDITIONAL(WITH_GNOME, test "$with_gnome" != no)
 AM_CONDITIONAL(WITH_LIBNM_GLIB, test "$with_libnm_glib" != no)