[orca] Convert list of details container role names into set



commit cdb7739ed301eedf0d274a3f3e120ff81c1b0afb
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Wed Feb 26 14:26:37 2020 +0100

    Convert list of details container role names into set
    
    If aria-details points to multiple targets with the same role, we want
    to summarize that information rather than repeat roles. We cannot do that
    without breaking string freeze, however. So for now, just list unique
    role names.

 src/orca/scripts/web/speech_generator.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/web/speech_generator.py b/src/orca/scripts/web/speech_generator.py
index 2ec9a1407..04b0b39f0 100644
--- a/src/orca/scripts/web/speech_generator.py
+++ b/src/orca/scripts/web/speech_generator.py
@@ -230,8 +230,8 @@ class SpeechGenerator(speech_generator.SpeechGenerator):
         if not objs:
             return []
 
-        objString = lambda x: "%s %s" % (x.name, self.getLocalizedRoleName(x))
-        toPresent = ", ".join(list(map(objString, objs)))
+        objString = lambda x: str.strip("%s %s" % (x.name, self.getLocalizedRoleName(x)))
+        toPresent = ", ".join(set(map(objString, objs)))
 
         args['stringType'] = 'hasdetails'
         result = [self._script.formatting.getString(**args) % toPresent]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]