[gnome-software/wip/jimmac/banner-border-radius] banners: sync border-radius with button tiles



commit 2f0cc1ecb8679385a5f9e1d5f30373351fbbf50c
Author: Jakub Steiner <jimmac gmail com>
Date:   Mon Feb 24 14:26:39 2020 +0100

    banners: sync border-radius with button tiles
    
    - remove redundant box-shadow overrides from featured xml
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-software/issues/895

 data/assets/org.gnome.Software.Featured.xml | 25 ++-----------------------
 src/gtk-style.css                           |  3 ++-
 2 files changed, 4 insertions(+), 24 deletions(-)
---
diff --git a/data/assets/org.gnome.Software.Featured.xml b/data/assets/org.gnome.Software.Featured.xml
index 515c2de7..92576d2c 100644
--- a/data/assets/org.gnome.Software.Featured.xml
+++ b/data/assets/org.gnome.Software.Featured.xml
@@ -27,7 +27,6 @@ background:
  url('file://@datadir@/gnome-software/featured-mypaint.svg')
  left 90% / 300px auto no-repeat,
  linear-gradient(to bottom, #ccc, #eee);
-box-shadow: none;
 </value>
     </custom>
   </component>
@@ -37,7 +36,7 @@ box-shadow: none;
       <value key="GnomeSoftware::FeatureTile-css">border-color: #deddda;
 text-shadow: none;
 color: #613583;
-box-shadow: none;
+
 background: #f6f5f4,
  url('file://@datadir@/gnome-software/featured-maps-overlay.svg')
  16px 16px / 20% auto no-repeat,
@@ -53,7 +52,6 @@ background: #f6f5f4,
 color: #fff;
 text-shadow: 0 1px #317e54, 
 -1px 0 #317e54;
-box-shadow: none;
 outline: none;
 background:
  linear-gradient(to bottom, rgba(105,108,116,0.3)),
@@ -68,7 +66,6 @@ background:
       <value key="GnomeSoftware::FeatureTile-css">border-color: #d65100;
 text-shadow: 0 1px 1px rgba(0,0,0,0.5);
 color: #ffffff;
-box-shadow: none;
 background:
  url('file://@datadir@/gnome-software/featured-transmission.svg')
  -20% center / 40% auto no-repeat, -gtk-gradient (radial,
@@ -144,7 +141,6 @@ background: linear-gradient(to bottom, rgba(255,214,172,0.8), rgba(255,214,172,0
             url('file://@datadir@/gnome-software/featured-kdenlive-bg.jpg')
  center / cover no-repeat;
 color: #df321e;
-box-shadow: none;
 text-shadow: none;</value>
     </custom>
   </component>
@@ -169,7 +165,6 @@ background: #fafafa url('file://@datadir@/gnome-software/featured-vlc-bg.jpg')
  left 13% / 90% auto no-repeat;
 background-size: cover;
 color: #222;
-box-shadow: none;
 text-shadow: 0 0 2px #fff;</value>
     </custom>
   </component>
@@ -182,7 +177,6 @@ text-shadow: 0 0 2px #fff;</value>
       <value key="GnomeSoftware::FeatureTile-css">border-color: #b47fba;
 text-shadow: 0 1px 1px rgba(0,0,0,0.5);
 color: #ffffff;
-box-shadow: none;
 background: url('http://people.gnome.org/~jimmac/gnome-software/spotify-logo.svg') 
  10% / 200px auto no-repeat, -gtk-gradient (linear, left top, left bottom, from(#b47fba), to(#000));</value>
     </custom>
@@ -206,7 +200,6 @@ text-shadow: none;</value>
       <value key="GnomeSoftware::FeatureTile-css">border-color: #d65100;
 text-shadow: 0 1px 1px rgba(0,0,0,0.5);
 color: #ffffff;
-box-shadow: none;
 background: #f5c211
  url('file://@datadir@/gnome-software/featured-FeedReader.svg')
  0 50% / 80% no-repeat;
@@ -217,7 +210,6 @@ background: #f5c211
     <id>com.bitwarden.desktop</id>
     <custom>
       <value key="GnomeSoftware::FeatureTile-css">border: 1px solid #1c6d8c;
-box-shadow: none;
 background: #2ec27e
  url('file://@datadir@/gnome-software/featured-bitwarden.svg')
  150% 80% / 60% auto no-repeat;
@@ -229,7 +221,6 @@ text-shadow: 0 0 2px #26a269;</value>
     <id>com.dropbox.Client</id>
     <custom>
       <value key="GnomeSoftware::FeatureTile-css">border: 1px solid #a8c3d6;
-box-shadow: none;
 text-shadow: 0 1px rgba(255,255,255,0.8);
 background: #b8d3e6 url('file://@datadir@/gnome-software/featured-dropbox.png') 
  left 40% / 100% auto no-repeat;
@@ -244,7 +235,6 @@ background: -gtk-gradient (linear, left top, right top, from(rgba(0,0,0,0)), to(
 url('file://@datadir@/gnome-software/featured-fondo-bg.jpg') center 20% no-repeat;
 background-size: cover;                
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -258,7 +248,6 @@ text-shadow: 0 1px 2px #000;</value>
 background: url('file://@datadir@/gnome-software/featured-darktable-bg.jpg') center 45% no-repeat;
 background-size: cover;                
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -272,7 +261,6 @@ text-shadow: 0 1px 2px #000;</value>
 background: url('file://@datadir@/gnome-software/featured-calibre-bg.jpg') center 45% repeat;
 background-size: cover;
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -283,7 +271,6 @@ text-shadow: 0 1px 2px #000;</value>
 background: url('file://@datadir@/gnome-software/featured-homebank-bg.jpg') center 45% repeat;
 background-size: cover;
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -295,8 +282,7 @@ background: #3584e4,
  url('file://@datadir@/gnome-software/featured-uberwriter.svg')
  10% center / 30% auto no-repeat;
 color: #fff;
-text-shadow: 0 0 3px #3584e4;
-box-shadow: none;</value>
+text-shadow: 0 0 3px #3584e4;</value>
     </custom>
   </component>
   <component>
@@ -306,7 +292,6 @@ box-shadow: none;</value>
 background: url('file://@datadir@/gnome-software/featured-klavaro-bg.jpg') center 45% repeat;
 background-size: cover;
 color: #000;
-box-shadow: none;
 text-shadow: 0 0 4px #fff;</value>
     </custom>
   </component>
@@ -314,7 +299,6 @@ text-shadow: 0 0 4px #fff;</value>
     <id>com.github.junrrein.PDFSlicer</id>
     <custom>
       <value key="GnomeSoftware::FeatureTile-css">border: 1px solid #1c6d8c;
-box-shadow: none;
 background: #3c8dbc 
  url('file://@datadir@/gnome-software/featured-pdf-slicer.svg')
  12px 70% / 30% auto no-repeat;
@@ -329,7 +313,6 @@ text-shadow: none;</value>
 background: url('file://@datadir@/gnome-software/featured-todo-bg.jpg') center 40% repeat;
 background-size: cover;
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -343,7 +326,6 @@ text-shadow: 0 1px 2px #000;</value>
 background: url('file://@datadir@/gnome-software/featured-marker-bg.jpg') center 45% repeat;
 background-size: cover;
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
@@ -353,7 +335,6 @@ text-shadow: 0 1px 2px #000;</value>
       <value key="GnomeSoftware::FeatureTile-css">border-color: #1b2838;
 text-shadow: 0 1px 1px rgba(0,0,0,0.5);
 color: #ffffff;
-box-shadow: none;
 background: #1b2838 url('http://people.gnome.org/~jimmac/gnome-software/steam-logo.svg') 
  10% / 200px auto no-repeat;</value>
     </custom>
@@ -365,7 +346,6 @@ background: #1b2838 url('http://people.gnome.org/~jimmac/gnome-software/steam-lo
 background: url('file://@datadir@/gnome-software/featured-tetravex-bg.jpg') center 45% repeat;
 background-size: cover;
 color: #000;
-box-shadow: none;
 text-shadow: 0 0 2px #fff;</value>
     </custom>
   </component>
@@ -377,7 +357,6 @@ background: -gtk-gradient (linear, left top, right top, from(rgba(0,0,0,0)), to(
 url('file://@datadir@/gnome-software/featured-stellarium-bg.jpg') center 20% no-repeat;
 background-size: cover;                
 color: #fff;
-box-shadow: none;
 text-shadow: 0 1px 2px #000;</value>
     </custom>
   </component>
diff --git a/src/gtk-style.css b/src/gtk-style.css
index 11689fe4..994833dc 100644
--- a/src/gtk-style.css
+++ b/src/gtk-style.css
@@ -235,9 +235,10 @@
 .featured-tile {
        all: unset;
        padding: 0;
-       border-radius: 3px;
+       border-radius: 5px; /* match button tiles */
        border-width: 1px;
        border-image: none;
+       box-shadow: none;
        /* box-shadow: inset 0 0 0 1px alpha(@theme_fg_color,0.3), 0 0 1px alpha(black,0.4); */
 }
   .featured-tile:backdrop label {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]