[gnome-control-center/background-spamming-journal] background: Don't warn for invalid xml tags



commit fbc3040c153c8e37dfd9259d470fbb5c93ec27ea
Author: Felipe Borges <felipeborges gnome org>
Date:   Fri Feb 21 13:42:36 2020 +0100

    background: Don't warn for invalid xml tags
    
    g_warning () is for environment errors. Additional tags than the
    ones we require are not necessarily an error.
    
    This behavior causes g-c-c to spam the journal with entries such
    as:
    
    Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: license
    Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: email
    Unknown Tag in /usr/share/gnome-background-properties/fedora-workstation-backgrounds.xml: author
    
    Where "license", "email", and "author" are valid tags that we just
    don't use.

 panels/background/cc-background-xml.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/panels/background/cc-background-xml.c b/panels/background/cc-background-xml.c
index 8f5871c03..270fcc2fb 100644
--- a/panels/background/cc-background-xml.c
+++ b/panels/background/cc-background-xml.c
@@ -271,7 +271,7 @@ cc_background_xml_load_xml_internal (CcBackgroundXml *xml,
        } else if (!strcmp ((gchar *)wpa->name, "text")) {
          /* Do nothing here, libxml2 is being weird */
        } else {
-         g_warning ("Unknown Tag in %s: %s", filename, wpa->name);
+         g_debug ("Unknown Tag in %s: %s", filename, wpa->name);
        }
       }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]