[evolution-data-server] EWebDAVCollectionBackend: Require credentials only if user name is set



commit a9c05ee0e1b8c4550079e3e6778574e4f332295c
Author: Milan Crha <mcrha redhat com>
Date:   Wed Feb 19 18:44:54 2020 +0100

    EWebDAVCollectionBackend: Require credentials only if user name is set
    
    This way users can configure WebDAV accounts for servers, which do not
    require authentication (aka those providing public calendars).
    
    Related to https://gitlab.gnome.org/GNOME/evolution/issues/668

 src/libebackend/e-webdav-collection-backend.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/libebackend/e-webdav-collection-backend.c b/src/libebackend/e-webdav-collection-backend.c
index cc1f67e3f..19bfc03e1 100644
--- a/src/libebackend/e-webdav-collection-backend.c
+++ b/src/libebackend/e-webdav-collection-backend.c
@@ -334,13 +334,15 @@ webdav_collection_backend_populate (ECollectionBackend *collection)
 
                if (e_source_has_extension (source, E_SOURCE_EXTENSION_AUTHENTICATION)) {
                        ESourceAuthentication *auth_extension;
-                       gchar *method;
+                       gchar *method, *user;
 
                        auth_extension = e_source_get_extension (source, E_SOURCE_EXTENSION_AUTHENTICATION);
                        method = e_source_authentication_dup_method (auth_extension);
-                       needs_credentials = g_strcmp0 (method, "OAuth2") != 0 &&
+                       user = e_source_authentication_dup_user (auth_extension);
+                       needs_credentials = user && *user && g_strcmp0 (method, "OAuth2") != 0 &&
                                !e_oauth2_services_is_oauth2_alias 
(e_source_registry_server_get_oauth2_services (server), method);
                        g_free (method);
+                       g_free (user);
                }
 
                if (needs_credentials) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]