[gtk/wip/baedert/for-master] spinbutton: Remove manual queue_draw() calls



commit de74da9a5ec633495ed529c339ff46fc30d10141
Author: Timm Bäder <mail baedert org>
Date:   Tue Feb 18 16:23:26 2020 +0100

    spinbutton: Remove manual queue_draw() calls
    
    Everything is automatically redrawn when changing the value, etc.

 gtk/gtkspinbutton.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)
---
diff --git a/gtk/gtkspinbutton.c b/gtk/gtkspinbutton.c
index 2248e7ffb4..97f076681b 100644
--- a/gtk/gtkspinbutton.c
+++ b/gtk/gtkspinbutton.c
@@ -833,8 +833,6 @@ start_spinning (GtkSpinButton *spin,
       g_source_set_name_by_id (priv->timer, "[gtk] gtk_spin_button_timer");
     }
   gtk_spin_button_real_spin (spin, click_child == priv->up_button ? step : -step);
-
-  gtk_widget_queue_draw (GTK_WIDGET (spin));
 }
 
 static void
@@ -1185,10 +1183,7 @@ gtk_spin_button_grab_notify (GtkWidget *widget,
   GTK_WIDGET_CLASS (gtk_spin_button_parent_class)->grab_notify (widget, was_grabbed);
 
   if (!was_grabbed)
-    {
-      if (gtk_spin_button_stop_spinning (spin))
-        gtk_widget_queue_draw (GTK_WIDGET (spin));
-    }
+    gtk_spin_button_stop_spinning (spin);
 }
 
 static void
@@ -1198,10 +1193,7 @@ gtk_spin_button_state_flags_changed (GtkWidget     *widget,
   GtkSpinButton *spin = GTK_SPIN_BUTTON (widget);
 
   if (!gtk_widget_is_sensitive (widget))
-    {
-      if (gtk_spin_button_stop_spinning (spin))
-        gtk_widget_queue_draw (GTK_WIDGET (spin));
-    }
+    gtk_spin_button_stop_spinning (spin);
 
   GTK_WIDGET_CLASS (gtk_spin_button_parent_class)->state_flags_changed (widget, previous_state);
 }
@@ -1263,7 +1255,6 @@ gtk_spin_button_value_changed (GtkAdjustment *adjustment,
   g_signal_emit (spin_button, spinbutton_signals[VALUE_CHANGED], 0);
 
   update_buttons_sensitivity (spin_button);
-  gtk_widget_queue_draw (GTK_WIDGET (spin_button));
 
   g_object_notify_by_pspec (G_OBJECT (spin_button), spinbutton_props[PROP_VALUE]);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]