[gnome-shell/gbsneto/remove-unnecessary-bind-constraint] appDisplay: Remove unnecessary bind constraint
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/remove-unnecessary-bind-constraint] appDisplay: Remove unnecessary bind constraint
- Date: Wed, 19 Feb 2020 12:24:02 +0000 (UTC)
commit b8f8e1710bcdd3bc5d07d5cefc6c3ab97b04c10d
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Wed Feb 19 09:20:05 2020 -0300
appDisplay: Remove unnecessary bind constraint
Now that the bind constraint changes the preferred size of
the actor, a major flaw in the AppDisplay code was exposed:
the folder dialog depends on the preferred size of a parent,
and the parent depends on the preferred size of the folder
dialog.
While we know this is not actually true, we shouldn't rely
on broken behavior to achieve this result. What's interesting
is that the bind constraint used by the folder dialog is a
relic of the development phase; we now control the position
and size of the dialog with a combination of CSS, and alignment.
Remove the unnecessary bind constraint.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/1027
js/ui/appDisplay.js | 4 ----
1 file changed, 4 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 01f87059ab..a602ba65db 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1657,10 +1657,6 @@ var AppFolderDialog = GObject.registerClass({
x_align: Clutter.ActorAlign.CENTER,
y_align: Clutter.ActorAlign.CENTER,
});
- this.add_constraint(new Clutter.BindConstraint({
- source: Main.overview.viewSelector,
- coordinate: Clutter.BindCoordinate.ALL,
- }));
this._source = source;
this._folder = folder;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]