[vala/staging] vala: Handle PointerType and VoidType in Constant.check_const_type()

[Rico Tzschichholz <ricotz src gnome org>]

commit 4f5221e7fe44ee5fb1a1df422d6e317ccd87d6ac
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Tue Feb 18 17:12:19 2020 +0100

    vala: Handle PointerType and VoidType in Constant.check_const_type()
    
    This caused criticals like:
    
      vala_typesymbol_is_subtype_of: assertion 'self != NULL' failed

 tests/Makefile.am                    | 1 +
 tests/semantic/constant-pointer.test | 6 ++++++
 vala/valaconstant.vala               | 2 ++
 3 files changed, 9 insertions(+)
---
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f683d18c7..071935bd1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -733,6 +733,7 @@ TESTS = \
        semantic/class-too-few-type-arguments.test \
        semantic/class-too-many-type-arguments.test \
        semantic/constant-extern.test \
+       semantic/constant-pointer.test \
        semantic/constant-value.test \
        semantic/constant-value-missing.test \
        semantic/constant-value-type.test \
diff --git a/tests/semantic/constant-pointer.test b/tests/semantic/constant-pointer.test
new file mode 100644
index 000000000..23235c23e
--- /dev/null
+++ b/tests/semantic/constant-pointer.test
@@ -0,0 +1,6 @@
+Invalid Code
+
+const int* FOO = 0;
+
+void main () {
+}
diff --git a/vala/valaconstant.vala b/vala/valaconstant.vala
index 3ff4bf3c4..809cb883d 100644
--- a/vala/valaconstant.vala
+++ b/vala/valaconstant.vala
@@ -185,6 +185,8 @@ public class Vala.Constant : Symbol {
        bool check_const_type (DataType type, CodeContext context) {
                if (type is ValueType) {
                        return true;
+               } else if (type is VoidType || type is PointerType) {
+                       return false;
                } else if (type is ArrayType) {
                        unowned ArrayType array_type = (ArrayType) type;
                        return check_const_type (array_type.element_type, context);