[gnome-boxes/gnome-3-34] vm-creator: Don't delete VMs automatically



commit a80ceafb4fdb5cc91ddb96aab8db46d63580584b
Author: Felipe Borges <felipeborges gnome org>
Date:   Fri Feb 7 12:02:49 2020 +0100

    vm-creator: Don't delete VMs automatically
    
    Boxes used to delete VMs automatically once the installer media
    is nowhere to be found. That is problematic because it can lead
    to users losing important data.
    
    In commit 81dbe5414431a045112a0cfcad881325fcb133e8 we offer a
    file chooser, so the user can continue the installation.
    
    Since we are past the UI/string freeze for gnome-3-36, let's just
    not delete the machines.
    
    Fixes #227

 src/vm-creator.vala | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/vm-creator.vala b/src/vm-creator.vala
index 8851bd4b..6eb04230 100644
--- a/src/vm-creator.vala
+++ b/src/vm-creator.vala
@@ -97,10 +97,7 @@ protected virtual async void continue_installation (LibvirtMachine machine) {
         }
 
         if (!FileUtils.test (install_media.device_file, FileTest.EXISTS)) {
-            warning ("Source installer media '%s' no longer exists. Deleting machine '%s'..",
-                     install_media.device_file,
-                     machine.name);
-            App.app.delete_machine (machine);
+            warning ("Source installer media '%s' no longer exists.", install_media.device_file);
             return;
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]