[gnome-music/wip/mschraal/gtk4: 89/141] notificationspopup: Remove show_all()



commit de81e1cacf7b520939867b20ecad4bb805d947f2
Author: Marinus Schraal <mschraal gnome org>
Date:   Thu Oct 31 13:22:00 2019 +0100

    notificationspopup: Remove show_all()

 gnomemusic/widgets/notificationspopup.py | 4 ----
 1 file changed, 4 deletions(-)
---
diff --git a/gnomemusic/widgets/notificationspopup.py b/gnomemusic/widgets/notificationspopup.py
index 25025149..0f0cd0ff 100644
--- a/gnomemusic/widgets/notificationspopup.py
+++ b/gnomemusic/widgets/notificationspopup.py
@@ -57,7 +57,6 @@ class NotificationsPopup(Gtk.Revealer):
         self._loading_notification.connect('invisible', self._set_visibility)
         self._grid.add(self._loading_notification)
 
-        self.show_all()
         self._loading_notification.hide()
 
     def _hide_notifications(self, notification, remove):
@@ -152,7 +151,6 @@ class LoadingNotification(Gtk.Grid):
         label = Gtk.Label(
             label=_("Loading"), halign=Gtk.Align.START, hexpand=True)
         self.add(label)
-        self.show_all()
 
     def pop(self):
         """Decrease the counter. Hide notification if it reaches 0."""
@@ -169,7 +167,6 @@ class LoadingNotification(Gtk.Grid):
     def push(self):
         """Increase the counter. Start notification if necessary."""
         def callback():
-            self.show_all()
             self.emit('visible')
 
         if self._counter == 0:
@@ -220,7 +217,6 @@ class PlaylistNotification(Gtk.Grid):
         undo_button = Gtk.Button.new_with_mnemonic(_("_Undo"))
         undo_button.connect("clicked", self._undo_deletion)
         self.add(undo_button)
-        self.show_all()
 
         if self.type_ == PlaylistNotification.Type.PLAYLIST:
             self._coremodel.stage_playlist_deletion(self._playlist)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]