[orca] Fix double-echoing of key when character echo is enabled in terminal apps



commit b569466548b543753006d7da1c88a0c2680feff7
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Mon Feb 17 12:54:24 2020 +0100

    Fix double-echoing of key when character echo is enabled in terminal apps

 src/orca/scripts/terminal/script.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/orca/scripts/terminal/script.py b/src/orca/scripts/terminal/script.py
index 0df16adde..8f240b3af 100644
--- a/src/orca/scripts/terminal/script.py
+++ b/src/orca/scripts/terminal/script.py
@@ -117,7 +117,7 @@ class Script(default.Script):
 
         self._sayAllIsInterrupted = False
         self.utilities.clearCachedCommandState()
-        if event.shouldEcho == False or event.isOrcaModified():
+        if event.shouldEcho == False or event.isOrcaModified() or event.isCharacterEchoable():
             return False
 
         # We have no reliable way of knowing a password is being entered into


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]