[glib: 3/5] GMainContext - Move mutex unlocking in destructor right before freeing the mutex



commit 730a75fc8e8271c38fbd5363d1f77a00876b9ddc
Author: Sebastian Dröge <sebastian centricular com>
Date:   Tue Feb 11 09:34:38 2020 +0200

    GMainContext - Move mutex unlocking in destructor right before freeing the mutex
    
    This does not have any behaviour changes but is cleaner. The mutex is
    only unlocked now after all operations on the context are done and right
    before freeing the mutex and the context itself.

 glib/gmain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/glib/gmain.c b/glib/gmain.c
index 41f1370d7..ee23a6519 100644
--- a/glib/gmain.c
+++ b/glib/gmain.c
@@ -585,7 +585,6 @@ g_main_context_unref (GMainContext *context)
       source = s_iter->data;
       g_source_destroy_internal (source, context, TRUE);
     }
-  UNLOCK_CONTEXT (context);
 
   for (sl_iter = context->source_lists; sl_iter; sl_iter = sl_iter->next)
     {
@@ -596,6 +595,7 @@ g_main_context_unref (GMainContext *context)
 
   g_hash_table_destroy (context->sources);
 
+  UNLOCK_CONTEXT (context);
   g_mutex_clear (&context->mutex);
 
   g_ptr_array_free (context->pending_dispatches, TRUE);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]