[orca] Don't treat iframes as inline unless they are contained in a document
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Don't treat iframes as inline unless they are contained in a document
- Date: Tue, 11 Feb 2020 14:22:21 +0000 (UTC)
commit 6a3d62200ffe465513dafe04542148303e3b40e0
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Tue Feb 11 15:19:25 2020 +0100
Don't treat iframes as inline unless they are contained in a document
Some apps (e.g. Thunderbird) report the top-level iframe as being inline.
We only care about the inline nature of iframes when they are contained
in a document (e.g. the Facebook like plugin)
src/orca/scripts/web/script_utilities.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 937b12d7e..6c53f6202 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -2110,7 +2110,10 @@ class Utilities(script_utilities.Utilities):
return False
displayStyle = self._getDisplayStyle(obj)
- return "inline" in displayStyle
+ if "inline" not in displayStyle:
+ return False
+
+ return self.documentForObject(obj) is not None
def isInlineIframeDescendant(self, obj):
if not obj:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]