[gnome-shell/gbsneto/new-lock-screen-part2: 39/63] unlockDialog: Don't destroy on cancel



commit 4ca7c7d5564e51b4f0793a3120d609df892eb0a0
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Thu Nov 28 19:47:58 2019 -0300

    unlockDialog: Don't destroy on cancel
    
    Otherwise there will be no way to recover it in the future. Also
    remove an else condition that assumed the dialog would destroy
    itself on cancel.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/872

 js/ui/screenShield.js | 2 --
 js/ui/unlockDialog.js | 2 --
 2 files changed, 4 deletions(-)
---
diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
index 918df05436..3d66a27374 100644
--- a/js/ui/screenShield.js
+++ b/js/ui/screenShield.js
@@ -191,8 +191,6 @@ var ScreenShield = class {
             // on its own, so ensure it stays on lock screen
             // instead
             this._lockScreenGroup.grab_key_focus();
-        } else {
-            this._dialog = null;
         }
     }
 
diff --git a/js/ui/unlockDialog.js b/js/ui/unlockDialog.js
index 70abd954e1..b819617943 100644
--- a/js/ui/unlockDialog.js
+++ b/js/ui/unlockDialog.js
@@ -499,8 +499,6 @@ var UnlockDialog = GObject.registerClass({
 
     cancel() {
         this._authPrompt.cancel();
-
-        this.destroy();
     }
 
     addCharacter(unichar) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]