[gnome-shell] theme/search-results: Use spacing instead of margin or padding

[Florian Müllner <fmuellner src gnome org>]

commit ddbc4ef42e5d97f424eda7ada50fb047b88e314a
Author: nana-4 <hnmaigo gmail com>
Date:   Sat Jan 25 18:58:33 2020 +0900

    theme/search-results: Use spacing instead of margin or padding
    
    Those margin and padding broke spacing in RTL layout. We should use
    regular `spacing` for them as before the refactoring.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957

 .../theme/gnome-shell-sass/widgets/_search-results.scss | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/widgets/_search-results.scss 
b/data/theme/gnome-shell-sass/widgets/_search-results.scss
index b067f47763..9836724bb3 100644
--- a/data/theme/gnome-shell-sass/widgets/_search-results.scss
+++ b/data/theme/gnome-shell-sass/widgets/_search-results.scss
@@ -3,17 +3,16 @@
 // search overview container
 #searchResultsContent {
   max-width: 1024px;
+  spacing: $base_margin * 2;
 }
 
 // search results sections "the boxes"
 .search-section {
+  // This should be equal to #searchResultsContent spacing
   spacing: $base_margin * 2;
-  background-color:transparent;
-  box-shadow:none;
-  border:none;
+
   // separator
   .search-section-separator { 
-    // margin-top: $base_padding * 2;
     // height: 1px;
     // background-color: $osd_outer_borders_color;
     height: 0;
@@ -30,8 +29,8 @@
   text-shadow: 0 1px if($variant == 'light', rgba(255,255,255,0.2), rgba(0,0,0,0.2));
   color: $osd_fg_color;
   padding: $base_padding * 3;
-  margin: $base_margin 0;
-  spacing: 0;
+  // This is the space between the provider icon and the results container
+  spacing: $base_margin * 2;
 }
 
 %search-section-content-item {
@@ -63,7 +62,6 @@
 // search result provider
 .search-provider-icon {
   @extend %search-section-content-item;
-  margin-right: $base_margin * 2;
 
   // content
   .list-search-provider-content {
@@ -90,13 +88,12 @@
 
   // content
   .list-search-result-content {
-    spacing: 0;
+    spacing: $base_padding;
   }
 
-  // list item title
+  // list item title (with leading icon)
   .list-search-result-title {
     spacing: $base_spacing * 2;
-    padding-right: $base_padding;
     // font-weight: bold;
   }