[gnome-shell/mcatanzaro/sandbox-portal-helper] Sandbox the portal helper
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/mcatanzaro/sandbox-portal-helper] Sandbox the portal helper
- Date: Wed, 5 Feb 2020 22:25:32 +0000 (UTC)
commit a8d117eeb24644e6af3cc499fccb5f1b96b3e7de
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Wed Feb 5 22:18:11 2020 +0000
Sandbox the portal helper
The portal helper is rather sensitive because potentially-hostile Wi-Fi
networks can decide to launch it whenever they want (by blocking the
user's connection to the nmcheck domain) and load whatever web content
they want into it. So having this unsandboxed is really extraordinarily
risky. Previously it was a risk we had to accept, because WebKit did not
have a web process sandbox, but now it does. So let's bubblewrap all the
things!
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/983
js/portalHelper/main.js | 4 ++++
1 file changed, 4 insertions(+)
---
diff --git a/js/portalHelper/main.js b/js/portalHelper/main.js
index b0e568dacb..3f8587d543 100644
--- a/js/portalHelper/main.js
+++ b/js/portalHelper/main.js
@@ -118,6 +118,10 @@ class PortalWindow extends Gtk.ApplicationWindow {
this._webContext = WebKit.WebContext.new_ephemeral();
this._webContext.set_cache_model(WebKit.CacheModel.DOCUMENT_VIEWER);
this._webContext.set_network_proxy_settings(WebKit.NetworkProxyMode.NO_PROXY, null);
+ if (WebKit.WebContext.set_sandbox_enabled) {
+ // We have WebKitGTK 2.26 or newer.
+ this._webContext.set_sandbox_enabled(true);
+ }
this._webView = WebKit.WebView.new_with_context(this._webContext);
this._webView.connect('decide-policy', this._onDecidePolicy.bind(this));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]