[gjs/master.msvc: 1/4] installed-tests/js/meson.build: Don't use -Wno-error on MSVC



commit 98236a5f1ed82cdf2dc6f6ae09b5b9d044e348e5
Author: Chun-wei Fan <fanchunwei src gnome org>
Date:   Wed Feb 5 15:13:30 2020 +0800

    installed-tests/js/meson.build: Don't use -Wno-error on MSVC
    
    This will cause the build to break as MSVC does not understand (nor like)
    -Wno-error.

 installed-tests/js/meson.build | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/installed-tests/js/meson.build b/installed-tests/js/meson.build
index 872d2e8b..e84a0c19 100644
--- a/installed-tests/js/meson.build
+++ b/installed-tests/js/meson.build
@@ -16,13 +16,15 @@ gidatadir = gi.get_pkgconfig_variable('gidatadir')
 gi_tests = gidatadir / 'tests'
 
 test_gir_extra_c_args = []
-# These consist of external code (from gobject-introspection) so they should not
-# error out even when building with -Werror
-test_gir_warning_c_args = ['-Wno-error']
+test_gir_warning_c_args = []
 
-# We need to ensure the symbols in the test DLLs export in MSVC builds
 if cc.get_id() == 'msvc'
+  # We need to ensure the symbols in the test DLLs export in MSVC builds
   test_gir_extra_c_args += ['-D_GI_EXTERN=__declspec(dllexport)extern']
+else
+  # These consist of external code (from gobject-introspection) so they should not
+  # error out even when building with -Werror
+  test_gir_warning_c_args += ['-Wno-error']
 endif
 
 regress_dependencies = [glib, gobject, gio]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]