[gnome-shell] shell/network-agent: Fix setting leak in get_secrets_keyring_cb
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] shell/network-agent: Fix setting leak in get_secrets_keyring_cb
- Date: Fri, 25 Dec 2020 22:07:41 +0000 (UTC)
commit f0deb03bd42478640c211931a2857a4b05631fc0
Author: Sebastian Keller <skeller gnome org>
Date: Mon Dec 14 15:51:46 2020 +0100
shell/network-agent: Fix setting leak in get_secrets_keyring_cb
The setting GVariant was not consumed by anything in the VPN case.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1535>
src/shell-network-agent.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/shell-network-agent.c b/src/shell-network-agent.c
index 9524fe5201..af5dfbb33b 100644
--- a/src/shell-network-agent.c
+++ b/src/shell-network-agent.c
@@ -243,7 +243,7 @@ get_secrets_keyring_cb (GObject *source,
GList *l;
gboolean secrets_found = FALSE;
GVariantBuilder builder_setting, builder_connection;
- GVariant *setting;
+ g_autoptr (GVariant) setting = NULL;
items = secret_service_search_finish (NULL, result, &secret_error);
@@ -303,7 +303,7 @@ get_secrets_keyring_cb (GObject *source,
}
g_list_free_full (items, g_object_unref);
- setting = g_variant_builder_end (&builder_setting);
+ setting = g_variant_ref_sink (g_variant_builder_end (&builder_setting));
/* All VPN requests get sent to the VPN's auth dialog, since it knows better
* than the agent about what secrets are required. Otherwise, if no secrets
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]