[mutter/wip/carlosg/crossings: 1/9] wayland: Don't explicitly repick on wl_surface destructor




commit 4c5ddd5e4e869a384594127a8ee5dbeaa4323c25
Author: Carlos Garnacho <carlosg gnome org>
Date:   Tue Dec 22 17:21:58 2020 +0100

    wayland: Don't explicitly repick on wl_surface destructor
    
    As the crash at https://gitlab.gnome.org/GNOME/mutter/-/issues/1584
    shows, this is already handled indirectly via the surface actor destruction
    paths (especifically, through changes in its reactiveness). We don't
    need repeating the operation here.

 src/wayland/meta-wayland-surface.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/src/wayland/meta-wayland-surface.c b/src/wayland/meta-wayland-surface.c
index 91684cc52b..0f0c55b1c7 100644
--- a/src/wayland/meta-wayland-surface.c
+++ b/src/wayland/meta-wayland-surface.c
@@ -1368,8 +1368,6 @@ wl_surface_destructor (struct wl_resource *resource)
   g_hash_table_destroy (surface->shortcut_inhibited_seats);
 
   g_object_unref (surface);
-
-  meta_wayland_compositor_repick (compositor);
 }
 
 MetaWaylandSurface *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]