[gvfs] mtp: Add TODO about introducing storage name duplicates
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs] mtp: Add TODO about introducing storage name duplicates
- Date: Wed, 16 Dec 2020 10:29:57 +0000 (UTC)
commit d45953ee95e259d8cc2bb63930992b932dd47134
Author: Niklas Hambüchen <mail nh2 me>
Date: Sun Nov 15 18:53:36 2020 +0100
mtp: Add TODO about introducing storage name duplicates
daemon/gvfsbackendmtp.c | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/daemon/gvfsbackendmtp.c b/daemon/gvfsbackendmtp.c
index 42c2955e..d3c6daf2 100644
--- a/daemon/gvfsbackendmtp.c
+++ b/daemon/gvfsbackendmtp.c
@@ -139,6 +139,9 @@ static char *create_storage_name (const LIBMTP_devicestorage_t *storage)
or not. Since this function is called in several places, it is
safest to perform this check here, each time that storage name needs
to be created. */
+ /* TODO: The returned name is not unique if suffix-adding happens
+ to introduce a collision with another storage's unsuffixed
+ description; unlikely but possible. */
gboolean is_unique = TRUE;
const LIBMTP_devicestorage_t *tmp_storage;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]