[glib/wip/pwithnall/freebsd-math: 2/3] gdatetime: Use isnan() instead of !isfinite()
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/wip/pwithnall/freebsd-math: 2/3] gdatetime: Use isnan() instead of !isfinite()
- Date: Fri, 11 Dec 2020 15:42:10 +0000 (UTC)
commit 50a3d0bf9def8f1b2c62b11dfba72189c44b77f9
Author: Philip Withnall <pwithnall endlessos org>
Date: Fri Dec 11 15:39:47 2020 +0000
gdatetime: Use isnan() instead of !isfinite()
Both are provided by libm, but `isnan()` is provided as a macro, whereas
`isfinite()` is an actual function, and hence libm has to be available
at runtime. That didn’t trivially work on FreeBSD, resulting in this
refactor.
`isfinite(x)` is equivalent to `!isnan(x) && !isinfinite(x)`. The case
of `x` being (negative or positive) infinity is already handled by the
range checks on the next line, so it’s safe to switch to `isnan()` here.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
glib/gdatetime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/glib/gdatetime.c b/glib/gdatetime.c
index 05e31202a..1d17d862f 100644
--- a/glib/gdatetime.c
+++ b/glib/gdatetime.c
@@ -1588,7 +1588,7 @@ g_date_time_new (GTimeZone *tz,
day < 1 || day > days_in_months[GREGORIAN_LEAP (year)][month] ||
hour < 0 || hour > 23 ||
minute < 0 || minute > 59 ||
- !isfinite (seconds) ||
+ isnan (seconds) ||
seconds < 0.0 || seconds >= 60.0)
return NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]