[orca] Handle another place where unknown coordinates were treated as offscreen
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Handle another place where unknown coordinates were treated as offscreen
- Date: Tue, 8 Dec 2020 09:20:36 +0000 (UTC)
commit 288156b093a5dca3c6feee042d840c688f84104f
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Tue Dec 8 10:20:06 2020 +0100
Handle another place where unknown coordinates were treated as offscreen
Apparently (-1, -1, -1, -1) is being used to specify an undetermined
bounding box. Therefore do not automatically treat an object with
these coordinates as off-screen. This will hopefully solve the flat
review failure seen with apps written in Gtk+ 3.24.24.
src/orca/script_utilities.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index 2ed14f520..54bf78f4d 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -1994,7 +1994,7 @@ class Utilities:
if boundingbox is None or not self._boundsIncludeChildren(obj.parent):
return True
- if not self.containsRegion(box, boundingbox):
+ if not self.containsRegion(box, boundingbox) and tuple(box) != (-1, -1, -1, -1):
msg = "INFO: %s %s not in %s" % (obj, box, boundingbox)
debug.println(debug.LEVEL_INFO, msg, True)
return False
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]