[orca] Don't treat unknown coordinates as definitely off-screen
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Don't treat unknown coordinates as definitely off-screen
- Date: Mon, 7 Dec 2020 16:47:26 +0000 (UTC)
commit 7740829c4af7582e1918d8177428f7f0cb2ac3db
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Mon Dec 7 17:40:59 2020 +0100
Don't treat unknown coordinates as definitely off-screen
Apparently (-1, -1, -1, -1) is being used to specify an undetermined
bounding box. Therefore do not automatically treat an object with
these coordinates as off-screen. This will hopefully solve the flat
review failure seen with apps written in Gtk+ 3.24.24.
src/orca/script_utilities.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index 8fa931449..2ed14f520 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -1974,7 +1974,7 @@ class Utilities:
debug.println(debug.LEVEL_INFO, msg, True)
return False
- if box.x < 0 and box.y < 0:
+ if box.x < 0 and box.y < 0 and tuple(box) != (-1, -1, -1, -1):
msg = "INFO: %s has negative coordinates" % obj
debug.println(debug.LEVEL_INFO, msg, True)
return False
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]