[gvfs/admin-add-copy-push-implementation: 1/2] admin: Add copy implementation for better performance
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs/admin-add-copy-push-implementation: 1/2] admin: Add copy implementation for better performance
- Date: Mon, 7 Dec 2020 13:20:24 +0000 (UTC)
commit 8970bb7bf81ce7bc89ea14deabc6172d5473299e
Author: Ondrej Holy <oholy redhat com>
Date: Mon Dec 7 12:09:01 2020 +0100
admin: Add copy implementation for better performance
Copying file within admin backend is slow in comparison to file://.
This is because copy vfunc is not implemented and thus read-write
fallback is used. Let's implement native copy to improve performance.
Fixes: https://gitlab.gnome.org/GNOME/gvfs/-/issues/530
daemon/gvfsbackendadmin.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
---
diff --git a/daemon/gvfsbackendadmin.c b/daemon/gvfsbackendadmin.c
index 9a7e8295..0bb6f9f1 100644
--- a/daemon/gvfsbackendadmin.c
+++ b/daemon/gvfsbackendadmin.c
@@ -807,6 +807,36 @@ do_move (GVfsBackend *backend,
complete_job (job, error);
}
+static void
+do_copy (GVfsBackend *backend,
+ GVfsJobCopy *copy_job,
+ const char *source,
+ const char *destination,
+ GFileCopyFlags flags,
+ GFileProgressCallback progress_callback,
+ gpointer progress_callback_data)
+{
+ GVfsBackendAdmin *self = G_VFS_BACKEND_ADMIN (backend);
+ GVfsJob *job = G_VFS_JOB (copy_job);
+ GError *error = NULL;
+ GFile *src_file, *dst_file;
+
+ if (!check_permission (self, job))
+ return;
+
+ src_file = g_file_new_for_path (source);
+ dst_file = g_file_new_for_path (destination);
+ g_file_copy (src_file, dst_file, flags,
+ job->cancellable,
+ progress_callback, progress_callback_data,
+ &error);
+
+ g_object_unref (src_file);
+ g_object_unref (dst_file);
+
+ complete_job (job, error);
+}
+
static void
do_pull (GVfsBackend *backend,
GVfsJobPull *pull_job,
@@ -972,6 +1002,7 @@ g_vfs_backend_admin_class_init (GVfsBackendAdminClass * klass)
backend_class->set_attribute = do_set_attribute;
backend_class->delete = do_delete;
backend_class->move = do_move;
+ backend_class->copy = do_copy;
backend_class->pull = do_pull;
backend_class->query_settable_attributes = do_query_settable_attributes;
backend_class->query_writable_namespaces = do_query_writable_namespaces;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]