[gnome-software: 2/4] plugins: Fix a few const-correctness compiler warnings

[Philip Withnall <pwithnall src gnome org>]

commit 0d4e1067e40ed261a7483a2369eac724a6c45585
Author: Philip Withnall <pwithnall endlessos org>
Date:   Wed Nov 25 12:45:20 2020 +0000

    plugins: Fix a few const-correctness compiler warnings
    
    As produced by clang. This doesn’t fix all the compiler warnings, but
    does remove some of them, which should making spotting actual bugs a bit
    easier in future.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 lib/gs-plugin-loader.c                 | 4 ++--
 plugins/odrs/gs-plugin-odrs.c          | 2 +-
 plugins/packagekit/packagekit-common.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index bb21be76..65fc3edd 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -656,8 +656,8 @@ gs_plugin_loader_call_vfunc (GsPluginLoaderHelper *helper,
        case GS_PLUGIN_ACTION_SEARCH_PROVIDES:
                {
                        GsPluginSearchFunc plugin_func = func;
-                       gchar *search[2] = { gs_plugin_job_get_search (helper->plugin_job), NULL };
-                       ret = plugin_func (plugin, search, list,
+                       const gchar *search[2] = { gs_plugin_job_get_search (helper->plugin_job), NULL };
+                       ret = plugin_func (plugin, (gchar **) search, list,
                                           cancellable, &error_local);
                }
                break;
diff --git a/plugins/odrs/gs-plugin-odrs.c b/plugins/odrs/gs-plugin-odrs.c
index ca834990..53c92abd 100644
--- a/plugins/odrs/gs-plugin-odrs.c
+++ b/plugins/odrs/gs-plugin-odrs.c
@@ -635,7 +635,7 @@ gs_plugin_odrs_refine_ratings (GsPlugin *plugin,
 
        for (guint i = 0; i < reviewable_ids->len; i++) {
                const gchar *id = g_ptr_array_index (reviewable_ids, i);
-               const GsOdrsRating search_rating = { id, { 0, }};
+               const GsOdrsRating search_rating = { (gchar *) id, { 0, }};
                guint found_index;
                const GsOdrsRating *found_rating;
 
diff --git a/plugins/packagekit/packagekit-common.c b/plugins/packagekit/packagekit-common.c
index ed77b341..db86bd84 100644
--- a/plugins/packagekit/packagekit-common.c
+++ b/plugins/packagekit/packagekit-common.c
@@ -459,7 +459,7 @@ gs_plugin_packagekit_details_array_to_hash (GPtrArray *array)
        for (gsize i = 0; i < array->len; i++) {
                PkDetails *details = g_ptr_array_index (array, i);
                g_hash_table_insert (details_collection,
-                                    pk_details_get_package_id (details),
+                                    (void *) pk_details_get_package_id (details),
                                     details);
        }