[tracker/wip/carlosg/insert-perf: 3/13] libtracker-data: Prefer tracker_class_get_id() over queries




commit 1733879a59bb1183062a7314c1f46f7a37cae5ae
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Nov 28 18:53:10 2020 +0100

    libtracker-data: Prefer tracker_class_get_id() over queries
    
    Drop one place where we did that, and some vestigial comment about it being
    done elsewhere in the past. Classes should indeed always have an ID,
    regardless of being parsed from ontology, retrieved from the database, or
    retrieved from gvdb.

 src/libtracker-data/tracker-data-update.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/src/libtracker-data/tracker-data-update.c b/src/libtracker-data/tracker-data-update.c
index a18bcff1c..0832a0b4d 100644
--- a/src/libtracker-data/tracker-data-update.c
+++ b/src/libtracker-data/tracker-data-update.c
@@ -970,7 +970,7 @@ tracker_data_resource_buffer_flush (TrackerData                      *data,
 
                                if (stmt) {
                                        tracker_db_statement_bind_int (stmt, 0, resource->id);
-                                       tracker_db_statement_bind_int (stmt, 1, ensure_resource_id (data, 
tracker_class_get_uri (table->class), NULL));
+                                       tracker_db_statement_bind_int (stmt, 1, tracker_class_get_id 
(table->class));
                                        tracker_db_statement_execute (stmt, &actual_error);
                                        g_object_unref (stmt);
                                }
@@ -1244,9 +1244,6 @@ cache_create_service_decomposed (TrackerData  *data,
 
        cache_insert_row (data, cl);
 
-       /* This is the original, no idea why tracker_class_get_id wasn't used here:
-        * class_id = ensure_resource_id (tracker_class_get_uri (cl), NULL); */
-
        class_id = tracker_class_get_id (cl);
        ontologies = tracker_data_manager_get_ontologies (data->manager);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]