[mutter] window: Add some trace instrumentation to implement show/hide
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter] window: Add some trace instrumentation to implement show/hide
- Date: Tue, 1 Dec 2020 12:05:02 +0000 (UTC)
commit 7eb20b2c3979eb5b37f42fecbf2c9732dacc99a7
Author: Jonas Ã…dahl <jadahl gmail com>
Date: Mon Nov 30 12:07:16 2020 +0100
window: Add some trace instrumentation to implement show/hide
Showing and hiding caused several second stalls, and still cause large
enough stalls to cause missed frames, makes this visible to Sysprof.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1616>
src/core/window.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
---
diff --git a/src/core/window.c b/src/core/window.c
index 2c9a7fbb5a..c43b83a259 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -1807,6 +1807,8 @@ idle_calc_showing (gpointer data)
GSList *displays;
guint queue_index = GPOINTER_TO_INT (data);
+ COGL_TRACE_BEGIN_SCOPED (MetaWindowCalcShowing, "Window: Calc showing");
+
g_return_val_if_fail (queue_pending[queue_index] != NULL, FALSE);
meta_topic (META_DEBUG_WINDOW_STATE,
@@ -1833,6 +1835,8 @@ idle_calc_showing (gpointer data)
unplaced = NULL;
displays = NULL;
+ COGL_TRACE_BEGIN (MetaWindowCalcShowingCalc, "Window: Calc showing (calc)");
+
tmp = copy;
while (tmp != NULL)
{
@@ -1857,6 +1861,11 @@ idle_calc_showing (gpointer data)
should_show = g_slist_sort (should_show, stackcmp);
should_show = g_slist_reverse (should_show);
+ COGL_TRACE_END (MetaWindowCalcShowingCalc);
+
+ COGL_TRACE_BEGIN (MetaWindowCalcShowingUnplaced,
+ "Window: Calc showing (calc unplaced)");
+
tmp = unplaced;
while (tmp != NULL)
{
@@ -1869,8 +1878,11 @@ idle_calc_showing (gpointer data)
tmp = tmp->next;
}
+ COGL_TRACE_END (MetaWindowCalcShowingUnplaced);
+
meta_stack_freeze (display->stack);
+ COGL_TRACE_BEGIN (MetaWindowCalcShowingShow, "Window: Calc showing (show)");
tmp = should_show;
while (tmp != NULL)
{
@@ -1882,7 +1894,9 @@ idle_calc_showing (gpointer data)
tmp = tmp->next;
}
+ COGL_TRACE_END (MetaWindowCalcShowingShow);
+ COGL_TRACE_BEGIN (MetaWindowCalcShowingHide, "Window: Calc showing (hide)");
tmp = should_hide;
while (tmp != NULL)
{
@@ -1894,8 +1908,12 @@ idle_calc_showing (gpointer data)
tmp = tmp->next;
}
+ COGL_TRACE_END (MetaWindowCalcShowingHide);
+ COGL_TRACE_BEGIN (MetaWindowCalcShowingSync,
+ "Window: Calc showing (sync stack)");
meta_stack_thaw (display->stack);
+ COGL_TRACE_END (MetaWindowCalcShowingSync);
tmp = copy;
while (tmp != NULL)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]