[vala/staging] libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [vala/staging] libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements
- Date: Thu, 27 Aug 2020 08:03:47 +0000 (UTC)
commit 721aca1abd3a8c27995874bfccd10e59842969ce
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Thu Aug 27 10:02:19 2020 +0200
    libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements
    
    This caused criticals like:
    
      g_uri_parse_scheme: assertion 'uri != NULL' failed
 libvaladoc/documentation/gtkdoccommentparser.vala | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/libvaladoc/documentation/gtkdoccommentparser.vala 
b/libvaladoc/documentation/gtkdoccommentparser.vala
index 20535b764..c1b1d0ea8 100644
--- a/libvaladoc/documentation/gtkdoccommentparser.vala
+++ b/libvaladoc/documentation/gtkdoccommentparser.vala
@@ -358,7 +358,12 @@ public class Valadoc.Gtkdoc.Parser : Object, ResourceLocator {
                }
 
                StringBuilder builder = new StringBuilder ();
-               string url = current.attributes.get ("linkend");
+               string url;
+               if (is_internal) {
+                       url = current.attributes.get ("linkend");
+               } else {
+                       url = current.attributes.get ("url");
+               }
                next ();
 
                // TODO: check xml
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]