[mutter] screen-cast: Increase size of maximum mouse pointer bitmap



commit 5037b88a2d97792ba523c24189aca3fab974653a
Author: Pascal Nowack <Pascal Nowack gmx de>
Date:   Sun Aug 23 08:12:08 2020 +0200

    screen-cast: Increase size of maximum mouse pointer bitmap
    
    Currently, the maximum size for a mouse pointer bitmap for screen
    casting is 64x64 pixels.
    However, this limit is hit way too often as it is way too low and
    results in crashes in either gnome-remote-desktop or mutter.
    For example: The a11y settings in g-c-c allow setting a larger pointer
    bitmap in order to increase the visibility of the mouse pointer.
    With the current limit of 64x64 pixels it is not possible to use the
    larger variants of the default mouse pointer bitmap, without
    experiencing any crash.
    Another way to hit the limit is when display scaling is used or some
    game uses a custom (large) mouse pointer bitmap.
    
    The VNC backend in gnome-remote-desktop does not seem to have a maximum
    pointer bitmap size.
    The RDP backend on the other hand has a maximum pointer bitmap size at
    384x384.
    
    Use this size (384x384) as maximum size instead of the current 64x64
    size for mouse pointer bitmaps to avoid crashes in mutter and
    gnome-remote-desktop and to ensure that bigger mouse pointer bitmaps
    can be used.
    
    https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1414

 src/backends/meta-screen-cast-stream-src.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/backends/meta-screen-cast-stream-src.c b/src/backends/meta-screen-cast-stream-src.c
index 198cc68955..1a90b01201 100644
--- a/src/backends/meta-screen-cast-stream-src.c
+++ b/src/backends/meta-screen-cast-stream-src.c
@@ -708,7 +708,7 @@ on_stream_param_changed (void                 *data,
     &pod_builder,
     SPA_TYPE_OBJECT_ParamMeta, SPA_PARAM_Meta,
     SPA_PARAM_META_type, SPA_POD_Id (SPA_META_Cursor),
-    SPA_PARAM_META_size, SPA_POD_Int (CURSOR_META_SIZE (64, 64)));
+    SPA_PARAM_META_size, SPA_POD_Int (CURSOR_META_SIZE (384, 384)));
 
   pw_stream_update_params (priv->pipewire_stream, params, G_N_ELEMENTS (params));
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]