[gdm/benzea/fix-unknown-session-crash: 2/2] manager: Always write out parameter
- From: Benjamin Berg <bberg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gdm/benzea/fix-unknown-session-crash: 2/2] manager: Always write out parameter
- Date: Fri, 21 Aug 2020 10:17:20 +0000 (UTC)
commit 11ec961ba69a42d5d8577e0fe314767ed7f44846
Author: Benjamin Berg <bberg redhat com>
Date: Fri Aug 21 12:15:47 2020 +0200
manager: Always write out parameter
The get_display_and_details_for_bus_sender function does not return a
proper error value. Due to this, it makes sense to always write the out
parameters (though, I expect we have still more that we might need to
write).
This is just slightly safer, but the function probably isn't great as
is.
daemon/gdm-manager.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c
index 25beecb5b..6f6c7c908 100644
--- a/daemon/gdm-manager.c
+++ b/daemon/gdm-manager.c
@@ -576,10 +576,11 @@ get_display_and_details_for_bus_sender (GdmManager *self,
lookup_by_session_id,
(gpointer) session_id);
+out:
if (out_display != NULL) {
*out_display = display;
}
-out:
+
g_free (session_id);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]