[libgda/wip/implicit_enums] GdaDataSelect: remove unnecessary internal function
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda/wip/implicit_enums] GdaDataSelect: remove unnecessary internal function
- Date: Wed, 12 Aug 2020 23:13:12 +0000 (UTC)
commit 7e11534b1fa881ea8ce5a588043db992844edc6c
Author: Daniel Espinosa <esodan gmail com>
Date: Wed Aug 12 18:08:50 2020 -0500
GdaDataSelect: remove unnecessary internal function
_gda_data_select_update_usage_flags() was used on one place
and its function was moved to gda-server-provider.c
libgda/gda-data-select.c | 13 -------------
libgda/gda-server-provider.c | 2 +-
libgda/providers-support/gda-data-select-priv.h | 1 -
3 files changed, 1 insertion(+), 15 deletions(-)
---
diff --git a/libgda/gda-data-select.c b/libgda/gda-data-select.c
index 6db311c7d..04f48d510 100644
--- a/libgda/gda-data-select.c
+++ b/libgda/gda-data-select.c
@@ -554,19 +554,6 @@ _gda_data_select_share_private_data (GdaDataSelect *model, GdaDataSelect *slave)
privs->sh = priv->sh;
}
-/*
- * Allows the #GdaServerProvider object to adjust the "model-usage" property for extra flags as OFFLINE and
- * ALLOW_NOPARAM. Only these flags are taken from @flags and added to the current "model-usage" flags of
@model.
- */
-void
-_gda_data_select_update_usage_flags (GdaDataSelect *model, GdaDataModelAccessFlags flags)
-{
- GdaDataModelAccessFlags eflags;
- GdaDataSelectPrivate *priv = gda_data_select_get_instance_private (model);
- eflags = priv->sh->usage_flags;
- eflags |= flags & (GDA_STATEMENT_MODEL_OFFLINE | GDA_STATEMENT_MODEL_ALLOW_NOPARAM);
- priv->sh->usage_flags = eflags;
-}
void
_gda_data_select_internals_free (GdaDataSelectInternals *inter)
diff --git a/libgda/gda-server-provider.c b/libgda/gda-server-provider.c
index 3090ba858..05c564a19 100644
--- a/libgda/gda-server-provider.c
+++ b/libgda/gda-server-provider.c
@@ -2529,7 +2529,7 @@ worker_statement_execute (WorkerExecuteStatementData *data, GError **error)
if (GDA_IS_DATA_SELECT (result)) {
/* adjust flags because the providers don't necessarily do it: make sure extra flags as
OFFLINE and
* ALLOW_NOPARAM are included */
- _gda_data_select_update_usage_flags ((GdaDataSelect*) result, data->model_usage);
+ data->model_usage = data->model_usage & (GDA_STATEMENT_MODEL_OFFLINE |
GDA_STATEMENT_MODEL_ALLOW_NOPARAM);
/* if necessary honor the OFFLINE flag */
if ((data->model_usage & GDA_STATEMENT_MODEL_OFFLINE) &&
diff --git a/libgda/providers-support/gda-data-select-priv.h b/libgda/providers-support/gda-data-select-priv.h
index c0eaff0ee..eb79c69ab 100644
--- a/libgda/providers-support/gda-data-select-priv.h
+++ b/libgda/providers-support/gda-data-select-priv.h
@@ -65,7 +65,6 @@ void gda_data_select_set_columns (GdaDataSelect *mode
void gda_data_select_add_exception (GdaDataSelect *model, GError *error);
/* internal API */
-void _gda_data_select_update_usage_flags (GdaDataSelect *model, GdaDataModelAccessFlags flags);
void _gda_data_select_share_private_data (GdaDataSelect *master, GdaDataSelect *slave);
G_END_DECLS
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]