[gnome-shell/gnome-3-36] popupMenu: Ungrab when removing active menu



commit a3d2cfa50326c95ea7598ba7971b2d4bcb67ca54
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Jul 28 17:50:58 2020 +0200

    popupMenu: Ungrab when removing active menu
    
    While we do have some handling for removing the active menu, it has
    been a no-op for years. The bit that we really care about from the
    PopupMenuManager's point of view is the existing grab though. Drop
    that instead of calling _closeMenu() directly; ungrabbing will still
    call the method indirectly, and it will still be a no-op :-)
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3022

 js/ui/popupMenu.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index 222dbe9c49..6d15261fd2 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -1325,7 +1325,7 @@ var PopupMenuManager = class {
 
     removeMenu(menu) {
         if (menu == this.activeMenu)
-            this._closeMenu(false, menu);
+            this._grabHelper.ungrab({ actor: menu.actor });
 
         let position = this._findMenu(menu);
         if (position == -1) // not a menu we manage


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]