[gtk/matthiasc/for-master: 6/6] placessidebar: Fix bookmarks dnd




commit 4eaf08e964f17b904bc759400f07180efeb8108c
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Aug 8 13:47:23 2020 -0400

    placessidebar: Fix bookmarks dnd
    
    We were not handling drops of bookmarks correctly,
    leading to criticals during DND.
    
    Fixes: #3037

 gtk/gtkplacessidebar.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index 531dd0e176..f72301e60f 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -1846,7 +1846,7 @@ drag_drop_callback (GtkDropTarget    *target,
 
   if (G_VALUE_HOLDS (value, GTK_TYPE_SIDEBAR_ROW))
     {
-      GtkWidget **source_row;
+      GtkWidget *source_row;
       /* A bookmark got reordered */
       if (target_section_type != SECTION_BOOKMARKS)
         goto out;
@@ -1856,7 +1856,7 @@ drag_drop_callback (GtkDropTarget    *target,
       if (sidebar->row_placeholder != NULL)
         g_object_get (sidebar->row_placeholder, "order-index", &target_order_index, NULL);
 
-      reorder_bookmarks (sidebar, GTK_SIDEBAR_ROW (*source_row), target_order_index);
+      reorder_bookmarks (sidebar, GTK_SIDEBAR_ROW (source_row), target_order_index);
       result = TRUE;
     }
   else if (G_VALUE_HOLDS (value, GDK_TYPE_FILE_LIST))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]