[gnome-games] preferences-page-platforms-retro-row: Use HdyComboRow

[Alexander Mikhaylenko <alexm src gnome org>]

commit 44f55d330f1c12c09a3455c563209a117230d2fb
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Fri Aug 7 03:21:36 2020 +0500

    preferences-page-platforms-retro-row: Use HdyComboRow
    
    Now that https://gitlab.gnome.org/GNOME/libhandy/-/merge_requests/594 is in
    we can use it.

 src/ui/preferences-page-platforms-retro-row.vala | 113 +++++------------------
 1 file changed, 25 insertions(+), 88 deletions(-)
---
diff --git a/src/ui/preferences-page-platforms-retro-row.vala 
b/src/ui/preferences-page-platforms-retro-row.vala
index 19a8a05f0..a7e985d4b 100644
--- a/src/ui/preferences-page-platforms-retro-row.vala
+++ b/src/ui/preferences-page-platforms-retro-row.vala
@@ -1,116 +1,53 @@
 // This file is part of GNOME Games. License: GPL-3.0+.
 
-[GtkTemplate (ui = "/org/gnome/Games/ui/preferences-page-platforms-retro-row.ui")]
-private class Games.PreferencesPagePlatformsRetroRow : Hdy.ActionRow {
-       [GtkChild]
-       private Gtk.Popover details_popover;
-       [GtkChild]
-       private Gtk.ListBox list_box;
-       [GtkChild]
-       private Gtk.Image dropdown_arrow;
-
-       private Settings settings;
-
-       private HashTable<Gtk.Widget, Retro.CoreDescriptor> row_cores;
-       private int num_cores;
-
+private class Games.PreferencesPagePlatformsRetroRow : Hdy.ComboRow {
        public RetroPlatform platform { get; construct; }
 
-       construct {
-               list_box.set_header_func (update_header);
-
-               title = platform.get_name ();
-
-               refresh_cores ();
-
-               var path = "/org/gnome/Games/platforms/%s/".printf (platform.get_id ());
-               settings = new Settings.with_path ("org.gnome.Games.platforms", path);
-
-               settings.changed.connect (update_label);
-       }
+       private ListStore model;
 
        public PreferencesPagePlatformsRetroRow (RetroPlatform platform) {
                Object (platform: platform);
        }
 
-       private void update_label () {
-               var core_manager = RetroCoreManager.get_instance ();
-               var preferred_core = core_manager.get_preferred_core (platform);
+       construct {
+               title = platform.get_name ();
 
-               if (preferred_core == null)
-                       /* Translators: This is displayed under the platform name when no
-                        * core is available for this platform. To see this message, click
-                        * on the hamburger menu, click on Preferences, then on Platforms */
-                       subtitle = _("None");
-               else {
-                       try {
-                               subtitle = preferred_core.get_name ();
-                       }
-                       catch (Error e) {
-                               critical (e.message);
-                       /* Translators: This is displayed under the platform name when no
-                        * core is available for this platform. To see this message, click
-                        * on the hamburger menu, click on Preferences, then on Platforms */
-                               subtitle = _("None");
-                       }
-               }
-       }
+               /* Translators: This is displayed under the platform name when no
+                * core is available for this platform. To see this message, click
+                * on the hamburger menu, click on Preferences, then on Platforms */
+               subtitle = _("None");
+               use_subtitle = true;
+
+               model = new ListStore (typeof (Retro.CoreDescriptor));
 
-       private void refresh_cores () {
                var core_manager = RetroCoreManager.get_instance ();
                var cores = core_manager.get_cores_for_platform (platform);
 
-               num_cores = cores.length;
-
-               sensitive = (num_cores > 0);
-               dropdown_arrow.visible = (num_cores > 1);
-               activatable = (num_cores > 1);
-
-               row_cores = new HashTable<Gtk.Widget, Retro.CoreDescriptor> (null, null);
+               foreach (var core in cores)
+                       model.append (core);
 
-               foreach (var core in cores) {
-                       try {
-                               var label = new Gtk.Label (core.get_name ());
-                               label.halign = Gtk.Align.START;
-                               label.margin = 12;
-                               label.show ();
+               notify["selected-index"].connect (notify_selected_index_cb);
 
-                               var row = new Gtk.ListBoxRow ();
-                               row.add (label);
-                               row.show ();
-                               row_cores[row] = core;
-
-                               list_box.add (row);
-                       }
-                       catch (Error e) {
-                               critical (e.message);
-                       }
-               }
-
-               update_label ();
+               bind_name_model (model, get_core_name);
        }
 
-       public override void activate () {
-               if (num_cores <= 1)
-                       return;
+       private string get_core_name (Object object) {
+               assert (object is Retro.CoreDescriptor);
 
-               details_popover.popup ();
-       }
+               var core = object as Retro.CoreDescriptor;
 
-       private void update_header (Gtk.ListBoxRow row, Gtk.ListBoxRow? before) {
-               if (before != null && row.get_header () == null) {
-                       var separator = new Gtk.Separator (Gtk.Orientation.HORIZONTAL);
-                       row.set_header (separator);
+               try {
+                       return core.get_name ();
+               }
+               catch (Error e) {
+                       return core.get_id ();
                }
        }
 
-       [GtkCallback]
-       private void on_row_activated (Gtk.ListBoxRow row) {
-               var core = row_cores[row];
+       private void notify_selected_index_cb () {
+               var core = model.get_item (selected_index) as Retro.CoreDescriptor;
 
                var core_manager = RetroCoreManager.get_instance ();
                core_manager.set_preferred_core (platform, core);
-
-               details_popover.popdown ();
        }
 }