[gtk/stop-blinking-without-moaning] text: Don't warn if we blink unfocused
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/stop-blinking-without-moaning] text: Don't warn if we blink unfocused
- Date: Thu, 6 Aug 2020 21:34:49 +0000 (UTC)
commit db023ba79a47fd4c3a688a992ced04f1db518df8
Author: Matthias Clasen <mclasen redhat com>
Date: Thu Aug 6 17:31:29 2020 -0400
text: Don't warn if we blink unfocused
The warning message contains advice that is no longer
accurate (it comes from a time before event controllers),
and this situation regularly happens in practice, when
the focus moves to a child of GtkText such as the menu or
the Emoji chooser. Just stop blinking without complaining.
Fixes: #2979
gtk/gtktext.c | 4 ----
1 file changed, 4 deletions(-)
---
diff --git a/gtk/gtktext.c b/gtk/gtktext.c
index 4317654df1..35c31e19fd 100644
--- a/gtk/gtktext.c
+++ b/gtk/gtktext.c
@@ -6427,10 +6427,6 @@ blink_cb (GtkWidget *widget,
if (!gtk_widget_has_focus (GTK_WIDGET (self)))
{
- g_warning ("GtkText - did not receive a focus-out event.\n"
- "If you handle this event, you must return\n"
- "GDK_EVENT_PROPAGATE so the self gets the event as well");
-
gtk_text_check_cursor_blink (self);
return G_SOURCE_REMOVE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]