[nautilus/wip/apoos-maximus/gsoc2020: 69/73] properties-window: Follow HIG layout advice
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus/wip/apoos-maximus/gsoc2020: 69/73] properties-window: Follow HIG layout advice
- Date: Sun, 2 Aug 2020 12:33:40 +0000 (UTC)
commit 9788942f8b3ab67e334dd650fc8f91f8e169784c
Author: António Fernandes <antoniof gnome org>
Date: Sun Jul 26 19:44:21 2020 +0100
properties-window: Follow HIG layout advice
We should use 6px for vertical spacing and 12px for horizontal spacing.
Also, prefer the GtkBox:spacing property over the padding child prop.
src/nautilus-properties-window.c | 2 +-
src/resources/ui/nautilus-properties-window.ui | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/src/nautilus-properties-window.c b/src/nautilus-properties-window.c
index 9f809587f..92652ad5c 100644
--- a/src/nautilus-properties-window.c
+++ b/src/nautilus-properties-window.c
@@ -4766,7 +4766,7 @@ setup_app_chooser_area (NautilusPropertiesWindow *window)
GAppInfo *info;
window->app_chooser_widget = gtk_app_chooser_widget_new (window->content_type);
- gtk_box_pack_start (GTK_BOX (window->app_chooser_widget_box), window->app_chooser_widget, TRUE, TRUE, 6);
+ gtk_box_pack_start (GTK_BOX (window->app_chooser_widget_box), window->app_chooser_widget, TRUE, TRUE, 0);
gtk_app_chooser_widget_set_show_default (GTK_APP_CHOOSER_WIDGET (window->app_chooser_widget), TRUE);
gtk_app_chooser_widget_set_show_fallback (GTK_APP_CHOOSER_WIDGET (window->app_chooser_widget), TRUE);
diff --git a/src/resources/ui/nautilus-properties-window.ui b/src/resources/ui/nautilus-properties-window.ui
index 620d12e5a..cced565b1 100644
--- a/src/resources/ui/nautilus-properties-window.ui
+++ b/src/resources/ui/nautilus-properties-window.ui
@@ -1253,6 +1253,7 @@
<property name="can_focus">False</property>
<property name="border_width">8</property>
<property name="orientation">vertical</property>
+ <property name="spacing">6</property>
<child>
<object class="GtkLabel" id="open_with_label">
<property name="visible">True</property>
@@ -1280,7 +1281,6 @@
<packing>
<property name="expand">True</property>
<property name="fill">True</property>
- <property name="padding">6</property>
<property name="position">1</property>
</packing>
</child>
@@ -1288,7 +1288,7 @@
<object class="GtkButtonBox" id="app_chooser_button_box">
<property name="visible">True</property>
<property name="can_focus">False</property>
- <property name="spacing">6</property>
+ <property name="spacing">12</property>
<property name="layout_style">end</property>
<child>
<object class="GtkButton" id="reset_button">
@@ -1335,7 +1335,6 @@
<packing>
<property name="expand">False</property>
<property name="fill">False</property>
- <property name="padding">6</property>
<property name="position">2</property>
</packing>
</child>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]