[gtk/ci-installed-tests: 1/5] togglebutton: Don't crash on click




commit a0705d5de471fdf5ed453f2451960796dbf8c80a
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Aug 1 20:09:05 2020 -0400

    togglebutton: Don't crash on click
    
    The code used to do
    if (parent_class->clicked)
      parent_class->clicked (...)
    That is pointless because the parent_class never changes,
    so there' no need for that if and commit 415946eb0f3b76ba25
    took it out. Unfortunately, p arent_class->clicked is NULL
    though, so the whole call needs to go.

 gtk/gtktogglebutton.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/gtk/gtktogglebutton.c b/gtk/gtktogglebutton.c
index 343efdb593..66c65f9a6e 100644
--- a/gtk/gtktogglebutton.c
+++ b/gtk/gtktogglebutton.c
@@ -185,8 +185,6 @@ gtk_toggle_button_clicked (GtkButton *button)
   GtkToggleButtonPrivate *priv = gtk_toggle_button_get_instance_private (toggle_button);
 
   gtk_toggle_button_set_active (toggle_button, !priv->active);
-
-  GTK_BUTTON_CLASS (gtk_toggle_button_parent_class)->clicked (button);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]