[gnome-todo] manager: Remove leftover property



commit b6785196f07c78c94d42f7942219cce0aedb8978
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Mon Apr 27 23:49:38 2020 -0300

    manager: Remove leftover property

 src/engine/gtd-manager.c                   | 47 +++++-------------------------
 src/task-list-view/gtd-task-list-popover.c | 12 --------
 2 files changed, 7 insertions(+), 52 deletions(-)
---
diff --git a/src/engine/gtd-manager.c b/src/engine/gtd-manager.c
index 35c58ee..a191184 100644
--- a/src/engine/gtd-manager.c
+++ b/src/engine/gtd-manager.c
@@ -153,16 +153,6 @@ compare_lists_cb (GtdTaskList *list_a,
   return gtd_collate_compare_strings (gtd_task_list_get_name (list_a), gtd_task_list_get_name (list_b));
 }
 
-static void
-on_default_list_changed_cb (GtdProvider *provider,
-                            GParamSpec  *pspec,
-                            GtdManager  *self)
-{
-  GTD_ENTRY;
-  g_object_notify (G_OBJECT (self), "default-task-list");
-  GTD_EXIT;
-}
-
 static void
 on_task_list_modified_cb (GtdTaskList *list,
                           GtdTask     *task,
@@ -331,7 +321,6 @@ on_provider_removed_cb (GtdPluginManager *plugin_manager,
   for (l = lists; l != NULL; l = l->next)
     on_list_removed_cb (provider, l->data, self);
 
-  g_signal_handlers_disconnect_by_func (provider, on_default_list_changed_cb, self);
   g_signal_handlers_disconnect_by_func (provider, on_list_added_cb, self);
   g_signal_handlers_disconnect_by_func (provider, on_list_changed_cb, self);
   g_signal_handlers_disconnect_by_func (provider, on_list_removed_cb, self);
@@ -776,38 +765,16 @@ void
 gtd_manager_set_default_provider (GtdManager  *self,
                                   GtdProvider *provider)
 {
-  GtdProvider *previous;
-
   g_return_if_fail (GTD_IS_MANAGER (self));
 
-  previous = self->default_provider;
+  if (!g_set_object (&self->default_provider, provider))
+    return;
 
-  if (g_set_object (&self->default_provider, provider))
-    {
-      g_settings_set_string (self->settings,
-                             "default-provider",
-                             provider ? gtd_provider_get_id (provider) : "local");
-
-      /* Disconnect the previous provider... */
-      if (previous)
-        {
-          g_signal_handlers_disconnect_by_func (previous,
-                                                on_default_list_changed_cb,
-                                                self);
-        }
-
-      /* ... and connect the current one */
-      if (provider)
-        {
-          g_signal_connect (provider,
-                            "notify::default-task-list",
-                            G_CALLBACK (on_default_list_changed_cb),
-                            self);
-        }
-
-      g_object_notify (G_OBJECT (self), "default-provider");
-      g_object_notify (G_OBJECT (self), "default-task-list");
-    }
+  g_settings_set_string (self->settings,
+                         "default-provider",
+                         provider ? gtd_provider_get_id (provider) : "local");
+
+  g_object_notify (G_OBJECT (self), "default-provider");
 }
 
 /**
diff --git a/src/task-list-view/gtd-task-list-popover.c b/src/task-list-view/gtd-task-list-popover.c
index 0e55433..50562fa 100644
--- a/src/task-list-view/gtd-task-list-popover.c
+++ b/src/task-list-view/gtd-task-list-popover.c
@@ -156,12 +156,6 @@ create_list_row_cb (gpointer item,
   return row;
 }
 
-static void
-on_default_tasklist_changed_cb (GtdTaskListPopover *self)
-{
-  set_selected_tasklist (self, NULL);
-}
-
 static void
 on_listbox_row_activated_cb (GtkListBox         *listbox,
                              GtkListBoxRow      *row,
@@ -258,12 +252,6 @@ gtd_task_list_popover_init (GtdTaskListPopover *self)
                            self,
                            NULL);
 
-  g_signal_connect_object (manager,
-                           "notify::default-task-list",
-                           G_CALLBACK (on_default_tasklist_changed_cb),
-                           self,
-                           G_CONNECT_SWAPPED);
-
   self->manager = manager;
 
   set_selected_tasklist (self, NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]