[tracker-miners/sam/debug-more: 5/5] tests/libtracker-miner: Avoid error message on test teardown



commit f5c6273d4c500f81e8f7327065ac951cea191e20
Author: Sam Thursfield <sam afuera me uk>
Date:   Sun Apr 26 00:27:15 2020 +0200

    tests/libtracker-miner: Avoid error message on test teardown
    
    We were deleting the database file before closing the database
    connection in some tests, which led to noise like this in the logs:
    
        Tracker-Message: 00:21:26.866: Could not get size for 
'file:///tmp/tracker-test-ZQDQJ0/.data/meta.db', Error when getting information for file 
“/tmp/tracker-test-ZQDQJ0/.data/meta.db”: No such file or directory

 tests/libtracker-miner/tracker-file-notifier-test.c | 6 +++---
 tests/libtracker-miner/tracker-miner-fs-test.c      | 5 +++--
 2 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/tests/libtracker-miner/tracker-file-notifier-test.c 
b/tests/libtracker-miner/tracker-file-notifier-test.c
index c3b036a20..7b8ebfd08 100644
--- a/tests/libtracker-miner/tracker-file-notifier-test.c
+++ b/tests/libtracker-miner/tracker-file-notifier-test.c
@@ -321,14 +321,14 @@ test_common_context_teardown (TestCommonContext *fixture,
                g_object_unref (fixture->test_file);
        }
 
+       g_clear_object (&fixture->connection);
+       g_main_loop_unref (fixture->main_loop);
+
        DELETE_FOLDER (fixture, NULL);
 
        if (fixture->test_path) {
                g_free (fixture->test_path);
        }
-
-       g_clear_object (&fixture->connection);
-       g_main_loop_unref (fixture->main_loop);
 }
 
 static gboolean
diff --git a/tests/libtracker-miner/tracker-miner-fs-test.c b/tests/libtracker-miner/tracker-miner-fs-test.c
index 0c6c7bd30..3d75e16fb 100644
--- a/tests/libtracker-miner/tracker-miner-fs-test.c
+++ b/tests/libtracker-miner/tracker-miner-fs-test.c
@@ -286,11 +286,12 @@ static void
 fixture_teardown (TrackerMinerFSTestFixture *fixture,
                   gconstpointer              data)
 {
-       DELETE_FOLDER (fixture, "/");
-
        g_object_unref (fixture->test_root);
        g_object_unref (fixture->miner);
        g_object_unref (fixture->connection);
+
+       DELETE_FOLDER (fixture, "/");
+
        g_free (fixture->test_root_path);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]