[vte] spawn: Remove unnecessary code



commit 7caf60301238a80ce53fc12fff159fbc57bb87df
Author: Christian Persch <chpe src gnome org>
Date:   Mon Apr 27 20:49:04 2020 +0200

    spawn: Remove unnecessary code
    
    All FDs are CLOEXEC anyway, so there's no need to explicitly close this FD.

 src/vtespawn.cc | 6 ------
 1 file changed, 6 deletions(-)
---
diff --git a/src/vtespawn.cc b/src/vtespawn.cc
index 23ec2c41..ab48782b 100644
--- a/src/vtespawn.cc
+++ b/src/vtespawn.cc
@@ -667,12 +667,6 @@ fork_exec (const gchar          *working_directory,
        */
       signal (SIGPIPE, SIG_DFL);
 
-      /* Close the parent's end of the pipes;
-       * not needed in the close_descriptors case,
-       * though. FIXMEchpe: remove this then since we always set all FDs CLOEXEC
-       */
-      close_and_invalidate (&child_err_report_pipe[0]);
-
       do_exec (child_err_report_pipe[1],
                working_directory,
                argv,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]