[gnome-terminal] screen: Fix memdup overrun



commit 5ae5b48b3f71dec024cd523b28f6bd2acbc8ced6
Author: Christian Persch <chpe src gnome org>
Date:   Sat Apr 25 21:59:50 2020 +0200

    screen: Fix memdup overrun
    
    The extra element was never accessed.

 src/terminal-screen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/terminal-screen.c b/src/terminal-screen.c
index 0cd16d6c..e90d530f 100644
--- a/src/terminal-screen.c
+++ b/src/terminal-screen.c
@@ -975,7 +975,7 @@ terminal_screen_exec (TerminalScreen *screen,
     const int *fds;
 
     fds = g_unix_fd_list_peek_fds (fd_list, &data->fd_list_len);
-    data->fd_list = g_memdup (fds, (data->fd_list_len + 1) * sizeof (int));
+    data->fd_list = g_memdup (fds, data->fd_list_len * sizeof (int));
     data->fd_array = g_variant_get_fixed_array (fd_array, &data->fd_array_len, 2 * sizeof (int));
   }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]